-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio playback on Linux #1511
Conversation
64566f4
to
3dda3c9
Compare
3dda3c9
to
e09bfca
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 70.90% 70.84% -0.07%
==========================================
Files 256 256
Lines 10817 10811 -6
==========================================
- Hits 7670 7659 -11
- Misses 3147 3152 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
||
void ensureMpvInitialized() { | ||
if (isMacOS) { | ||
NativeLibrary.ensureInitialized(libmpv: '/opt/homebrew/bin/mpv'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
media_kit bundles libmpv within media_kit_libs_macos_audio
, by the way.
I'm not sure how if using external version will be a good idea.
Also... silly me. I forgot passing this argument in MediaKit.ensureInitialized
.
What a goofy bug. I'm adding tests. It'll be addressed in next update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, that means I can remove that hack after updating the lib? Awesome, thanks for fixing it, felt like an odd hack having to do that to make the tests pass. Should have filed an issue right away :]
@@ -1,4 +1,4 @@ | |||
platform :osx, '10.15' | |||
platform :osx, '11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're reducing the minimum supported macOS version (if it matters) to improve backwards compatibility:
media-kit/libmpv-darwin-build#7
Also, may I suggest It can make huge difference. In current APK:
For each architecture, say arm64-v8a, media_kit adds about 5 MB to provide a really strong (in terms of codec support & performance). Current 130 MB is undoubtedly very large. Out of which, most can be reduced with compression (possibly automatically done with |
@alexmercerind thanks a lot, yeah I noticed that the APK had grown quite substantially recently after adding |
Resolves #1510 by replacing
[just_audio
](https://pub.dev/packages/just_audio) withmedia_kit
since the former did not support Linux.